Separate build script data from compile_data#21
Open
michaelm-openai wants to merge 1 commit intohermeticbuild:mainfrom
Open
Separate build script data from compile_data#21michaelm-openai wants to merge 1 commit intohermeticbuild:mainfrom
michaelm-openai wants to merge 1 commit intohermeticbuild:mainfrom
Conversation
Keep cargo build script inputs available to their direct dependent without propagating them through transitive Rustc inputs. compile_data remains reserved for files that need to stay available to downstream consumers, such as generated link inputs. Update the existing cargo_build_script propagation test to distinguish the direct-dependent case from the transitive case. Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep cargo build script inputs available to their direct dependent without propagating them through transitive Rustc inputs. compile_data remains reserved for files that need to stay available to downstream consumers, such as generated link inputs.
Update the existing cargo_build_script propagation test to distinguish the direct-dependent case from the transitive case.